Make TcfEuV2's IsServiceSpecific not a condition for encoding Vendors…

[shawjef3]

…Allowed or VendorsDisclosed.

TcfEuV2#encodeSection() now uses the same criteria as iabtcf-java's TCStringEncoder to determine if a segment should be encoded.

TCF 2.3 makes VendorsDisclosed required, and so its encoding should not be conditional on IsServiceSpecific.

I made additional changes to reduce the amount of whitespace.

TcfEuV2#encodeSection() no longer creates an intermediate collection.

[shawjef3]

This is for #83.

[yuzawa-san]

i have ported a similar change into the beta/4.X branch in d14a86b

[HeinzBaumann]

LGTM

[shawjef3]

@yuzawa-san @HeinzBaumann are either of you able to merge this? I don't have permission.

[lamrowena]

@shawjef3 similar change was included in the 4.X branch which was merged, could you test that branch?

[shawjef3]

@lamrowena The 4.x branch looks good. I used the following test. It would be good to merge and publish this anyway. Some people might not have the luxury of upgrading their JVM.

@Test
public void testIsServiceSpecific() {
  final TcfEuV2 tcfEuV2 = new TcfEuV2();
  tcfEuV2.setFieldValue(TcfEuV2Field.IS_SERVICE_SPECIFIC, false);
  final IntegerSet expectedVendorsDisclosed = new IntegerSet();
  expectedVendorsDisclosed.add(1);
  tcfEuV2.setFieldValue(TcfEuV2Field.VENDORS_DISCLOSED, expectedVendorsDisclosed);
  final IntegerSet expectedVendorsAllowed = new IntegerSet();
  expectedVendorsAllowed.add(2);
  tcfEuV2.setFieldValue(TcfEuV2Field.VENDORS_ALLOWED, expectedVendorsAllowed);
  final String encoded = tcfEuV2.encode();
  final TcfEuV2 decoded = new TcfEuV2(encoded);
  Assertions.assertEquals(expectedVendorsDisclosed, decoded.getVendorsDisclosed());
  Assertions.assertEquals(expectedVendorsAllowed, decoded.getVendorsAllowed());
}