This repository was archived by the owner on Mar 14, 2019. It is now read-only.
Update the manage scripts to use platform independent docker host sni…#12
Open
swcurran wants to merge 1 commit into
Open
Update the manage scripts to use platform independent docker host sni…#12swcurran wants to merge 1 commit into
swcurran wants to merge 1 commit into
Conversation
…ffer Signed-off-by: Stephen Curran <swcurran@gmail.com>
Author
|
The current approach for determining the DOCKERHOST does not work on Windows. This approach is platform independent. |
Contributor
|
@swcurran Have you tested on OSX? It doesn't seem to return a valid ip address for me. |
Author
|
@brycecurtis - yes, we use that approach on all platforms. It's why we use it. Here is an article that explains the approach: https://che.eclipse.org/discovering-dockers-ip-address-2bb524b0cb28 Did you try the manage scripts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ffer
Signed-off-by: Stephen Curran swcurran@gmail.com