Refresh lockfile for security patches, fix mypy 2.x/stale config, fix publish trigger - #26
Merged
Merged
Conversation
… publish trigger uv lock --upgrade closes the remaining Dependabot alerts not covered by the merged Renovate PRs: starlette 1.3.1 (SSRF/host-header/form-limit issues), idna 3.18 (ReDoS). That upgrade pulled in mypy 2.3.0, which surfaced two issues unrelated to the security work: - mypy.ini pinned python_version = 3.9, which mypy 2.x refuses to target (minimum 3.10) and which was already stale — pyproject.toml requires >=3.11. Corrected to 3.11. - With the correct target, mypy now understands 3.11's exception-group syntax and caught a real type mismatch: _is_benign_shutdown_exc was typed to take Exception but is called with items pulled from BaseExceptionGroup.exceptions, which can be any BaseException. The function body only calls str(exc), so widening the parameter to BaseException is correct, not just a suppression. - mcp_pydantic_base.py: fn() narrows Any to type[object] once guarded by hasattr(expected, '__bases__'), so mypy loses sight of the dynamic constructor call. Scoped type: ignore[call-arg] with explanation, matching the same pattern already used elsewhere in this file for structurally similar dynamic dispatch. publish.yml only triggered on 'release: published', but GitHub Actions blocks GITHUB_TOKEN-authored events (which is what Create Release uses) from triggering other workflows, so it never actually fired on tag releases. Added a direct 'push: tags: v*.*.*' trigger plus a tag/ pyproject.toml version guard, matching chuk-artifacts/chuk-virtual-fs/ chuk-sessions/chuk-mcp-runtime. The pypi GitHub Environment already existed here. Signed-off-by: chris hay <chris.hay@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan