Skip to content

Miscellaneous pagination fixes#701

Merged
ricellis merged 6 commits intomainfrom
pagination-fixes
Jul 9, 2025
Merged

Miscellaneous pagination fixes#701
ricellis merged 6 commits intomainfrom
pagination-fixes

Conversation

@ricellis
Copy link
Copy Markdown
Member

@ricellis ricellis commented Jul 3, 2025

PR summary

Fixes: s1187

Note: An existing issue is required before opening a PR.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

The new (unreleased) pagination code delivered in #696 had some bugs.

What is the new behavior?

  • Disallow key as an option for pagination
  • Fix NPEs for reduced/grouped view results with null IDs
  • Fix page size adjustment for key-based (n+1) pagination
  • Remove skip option from subsequent pages
  • Add new test assertions to check page size against options
  • Add new tests for key option validation
  • Add new tests for asserting skip option changes
  • Refactor the OptionsHandler to accommodate these changes and move some functionality out of the page iterator classes as a result
  • Adapt the BasePageIteratorTest to not be an n+1/key pager

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ricellis ricellis self-assigned this Jul 3, 2025
@mojito317 mojito317 self-requested a review July 8, 2025 11:12
@ricellis ricellis force-pushed the pagination-fixes branch from 05db78e to 97ea3a9 Compare July 8, 2025 15:28
Copy link
Copy Markdown
Contributor

@mojito317 mojito317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I left one tiny nit only.

@ricellis ricellis force-pushed the pagination-fixes branch from f4a3bb7 to e8b3a4d Compare July 9, 2025 16:38
@ricellis ricellis merged commit 124920e into main Jul 9, 2025
8 checks passed
@ricellis ricellis deleted the pagination-fixes branch July 9, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants