fix: DesignDocsPageIterator class modifiers#758
Merged
Conversation
eiri
approved these changes
Oct 8, 2025
3ba2e1c to
8ca8143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fix the class modifiers on
DesignDocsPageIteratorFixes: part of s1082
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
DesignDocsPageIteratorispublicwhen it is not meant to be (it is internal and is only meant to be used viaPagination).What is the new behavior?
DesignDocsPageIteratoris markedfinal(and default package visibility).Does this PR introduce a breaking change?
Paginationclass and the constructor was notpublicOther information