Skip to content

fix: DesignDocsPageIterator class modifiers#758

Merged
ricellis merged 1 commit intomainfrom
fix-pagination-visibility
Oct 9, 2025
Merged

fix: DesignDocsPageIterator class modifiers#758
ricellis merged 1 commit intomainfrom
fix-pagination-visibility

Conversation

@ricellis
Copy link
Copy Markdown
Member

@ricellis ricellis commented Oct 8, 2025

PR summary

Fix the class modifiers on DesignDocsPageIterator

Fixes: part of s1082

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

DesignDocsPageIterator is public when it is not meant to be (it is internal and is only meant to be used via Pagination).

What is the new behavior?

DesignDocsPageIterator is marked final (and default package visibility).

Does this PR introduce a breaking change?

  • Yes
  • No - the class should only be used via the Pagination class and the constructor was not public

Other information

@ricellis ricellis self-assigned this Oct 8, 2025
@ricellis ricellis force-pushed the fix-pagination-visibility branch from 3ba2e1c to 8ca8143 Compare October 8, 2025 16:54
@ricellis ricellis merged commit 13a327a into main Oct 9, 2025
9 checks passed
@ricellis ricellis deleted the fix-pagination-visibility branch October 9, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants