Conversation
ricellis
force-pushed
the
s1260-readme-tests
branch
2 times, most recently
from
e463eef to
c585745
Compare
eiri
approved these changes
Nov 28, 2025
Contributor
eiri
left a comment
eiri
left a comment
There was a problem hiding this comment.
lgtm, but don't forget to remove exampleDocument.setRev(createDocumentResponse.getRev()); bit from CreateDbAbdDoc before merging.
ricellis
force-pushed
the
s1260-readme-tests
branch
from
c585745 to
1caa2a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Add tests to check README examples work
Fixes: s1260
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
README examples code has no tests.
What is the new behavior?
modules/examples/src/test/java/ReadmeIntegrationTest.javaruns each README example file and compares the output against what is expected/included in the README.Does this PR introduce a breaking change?
Other information