Add accessible_topology to created volumes, closes #828#845
Open
bh-tt wants to merge 1 commit intoIBM:release-1.13.1from
Open
Add accessible_topology to created volumes, closes #828#845bh-tt wants to merge 1 commit intoIBM:release-1.13.1from
bh-tt wants to merge 1 commit intoIBM:release-1.13.1from
Conversation
Signed-off-by: Bert Helderman <bert@transtrend.com>
shlomitn
force-pushed
the
release-1.13.1
branch
5 times, most recently
from
8a5fa1f to
222840f
Compare
shlomitn
force-pushed
the
release-1.13.1
branch
5 times, most recently
from
aa1a5a2 to
c59c90a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the selected topology for the volume to the CSI response. This causes kubernetes to append a NodeAffinity to the created PersistentVolume, making sure that Pods using this volume are automatically scheduled on Nodes that can access the IBM storage selected for the volume.
I'm finding it hard to actually run tests or CI, so forgive me if I use this PR as a test runner.