Fix ztensor_slice_dim4 invalid-layout error message#74
Open
k8ika0s wants to merge 1 commit into
Open
Conversation
What: Report the pre-transformed layout (not transformed layout) in ztensor_slice_dim4 invalid-layout diagnostics. Why: Incorrect error wording misleads integrators and slows down debugging of layout misuse. Expected impact: Clearer, correct diagnostics with stable regression coverage. Tests: assert error message content (tests/testDriver_slice_dim4_error_message.c). Signed-off-by: Kaitlyn Davis <k8ika0s@gmail.com> Signed-off-by: Kaitlyn Davis <kaitlyn.davis@ibm.com>
k8ika0s
requested review from
Andreas-Krebbel,
n-marion and
stbjones
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44
Summary
ztensor_slice_dim4invalid-layout error message.Why
ztensor_slice_dim4Invalid-Layout Error Message (Report Pre-Transformed Layout) #44 for the full problem statement, justification, and acceptance criteria.Changes
qe/issue-05-slice-dim4-error-message.Validation
artifacts/final-validation-20260212T173158Z.Notes