Add prepared quantized matmul context APIs#81
Open
k8ika0s wants to merge 3 commits into
Open
Conversation
What: Add optional prepare/execute/release APIs for repeated quantized matmul with stable descriptors. Why: Repeated-shape inference loops otherwise redo setup and scratch handling each call. Expected impact: Lower per-call CPU overhead for repeated quantized matmul workloads; additive opt-in API. Tests: add dedicated coverage for prepared lifecycle and invariants (tests/testDriver_quantized_matmul_prepared_context.c). Signed-off-by: Kaitlyn Davis <k8ika0s@gmail.com> Signed-off-by: Kaitlyn Davis <kaitlyn.davis@ibm.com>
The prepared quantized matmul context previously depended on the separate\nwork-area sizing helper API. Compute qc_tilde sizing locally instead so this\nPR remains self-contained (only requires scratch-buffer support) and does not\nintroduce a hidden dependency on work_area.c helper changes. Signed-off-by: Kaitlyn Davis <k8ika0s@gmail.com> Signed-off-by: Kaitlyn Davis <kaitlyn.davis@ibm.com>
What: Replace prepared-context scratch API usage with internal aligned buffer management so the branch can stand alone on main. Why: Issue 12 previously depended on Issue 11 types/functions; this change removes that branch dependency while preserving behavior. Expected impact: Prepared quantized matmul remains functionally equivalent and independently PR-able to main. Tests: update prepared-context tests for internal buffer fields. Signed-off-by: Kaitlyn Davis <k8ika0s@gmail.com> Signed-off-by: Kaitlyn Davis <kaitlyn.davis@ibm.com>
k8ika0s
requested review from
Andreas-Krebbel,
n-marion and
stbjones
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51
Summary
Why
Changes
qe/issue-12-prepared-quantized-matmul-context.Validation
artifacts/final-validation-20260212T173158Z.Notes