Refactor credential transformations to share iteration#13116
Merged
Refactor credential transformations to share iteration#13116
Conversation
Extract a `credential_holders` iterator yielding `(parameters, keys)` for sources and issue trackers, and rewrite `hide_credentials`, `encrypt_credentials`, and `decrypt_credentials` to use the iterator. Also add an `issue_trackers` iterator alongside `subjects` / `metrics` / `sources`. Preparatory refactor for #12901. Closes #13115.
fniessink
force-pushed
the
13115-refactor-transformations
branch
from
afd6a3b to
50927bb
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract a
credential_holdersiterator yielding(parameters, keys)for sources and issue trackers, and rewritehide_credentials,encrypt_credentials, anddecrypt_credentialsto use the iterator. Also add anissue_trackersiterator alongsidesubjects/metrics/sources.Preparatory refactor for #12901.
Closes #13115.