Extensions - Fix acre2.ini Configuration Path#1377
Open
Apricot-ale wants to merge 3 commits intoIDI-Systems:masterfrom
Open
Extensions - Fix acre2.ini Configuration Path#1377Apricot-ale wants to merge 3 commits intoIDI-Systems:masterfrom
Apricot-ale wants to merge 3 commits intoIDI-Systems:masterfrom
Conversation
getTempFilePath is not related with acre2.ini it's same as %WinDir%\Temp
idiot!
Member
|
Double slashes shouldn't be a problem. |
Contributor
Author
Yes, this isn't a big problem, and the necessary data is included by the fallback. Well, since acre2.ini is no longer needed by anyone, and this PR is mainly to eliminate the error, we might as just remove the entirely acre2.ini things instead. |
Member
|
Removing it would be ideal. I am not sure if its really not being used by something though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Example of Error:
ts3Functions.getConfigPath(
tempFolder) is maybe returnAppData\Roaming\TS3Client\\\acre2is return\acre2so
tempFolder += "\\acre";is returnsAppData\Roaming\TS3Client\\acreI'm not familiar with C, so please correct me if this is a problem.
Also, I haven't tried this fix yet because I don't know how to build and test the plugin...