WIP: Write radio sound files from pbo to temp folder (drop b64)#978
Open
PabstMirror wants to merge 1 commit intomasterfrom
Open
WIP: Write radio sound files from pbo to temp folder (drop b64)#978PabstMirror wants to merge 1 commit intomasterfrom
PabstMirror wants to merge 1 commit intomasterfrom
Conversation
Member
|
So yea, there is no reason we have to use b64 still, since it was a relic of the pre-pbo code. Also I don't think there is a need to copy them to a temp folder. We are storing them and playing them from memory in the sound system if I remember right. We should be able to just pass a path from Arma to the extension and pull it into memory from the pbo like we do with the wrps. |
Member
|
I think we should leave the old b64 functionality though imo to have backwards compat. |
TheMagnetar
requested changes
Jun 11, 2020
| file_entry() {}; | ||
| file_entry(file_p entry_) : _file(entry_) { | ||
| file_entry() = delete; | ||
| file_entry(file_p entry_) : _file(entry_) { |
Member
There was a problem hiding this comment.
Suggested change
| file_entry(file_p entry_) : _file(entry_) { | |
| explicit file_entry(file_p entry_) : _file(entry_) { |
| public: | ||
| file_entry() {}; | ||
| file_entry(file_p entry_) : _file(entry_) { | ||
| file_entry() = delete; |
Member
There was a problem hiding this comment.
No need to delete. Simply delete the constructor.
Suggested change
| file_entry() = delete; | |
| file_entry() = delete; |
PabstMirror
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy radio sounds directly from pbo instead of loading b64 files
I'm really not sure if this is a good idea or not
Plus:
Negative: