Fix/enforce additional properties on refs#185
Merged
kilojoules merged 2 commits intoIEAWindSystems:mainfrom Mar 24, 2026
Merged
Fix/enforce additional properties on refs#185kilojoules merged 2 commits intoIEAWindSystems:mainfrom
kilojoules merged 2 commits intoIEAWindSystems:mainfrom
Conversation
… schemas _enforce_no_additional_properties only processed the root schema dict and did not follow $ref links. Schemas loaded via the registry (e.g. site.yaml, wind_farm.yaml) were never patched with additionalProperties: false, so extra properties in referenced schemas passed validation silently. Use a closure-based retrieve function that applies the enforcement to referenced schemas when restrictive=True. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verifies that additional properties in schemas loaded via $ref are rejected when restrictive=True. Without the registry fix, this test fails because enforcement never reaches referenced schemas. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bayc
approved these changes
Mar 5, 2026
Collaborator
bayc
left a comment
bayc
left a comment
There was a problem hiding this comment.
Thanks for fixing this bug @kilojoules !
kenloen
approved these changes
Mar 11, 2026
Collaborator
kenloen
left a comment
kenloen
left a comment
There was a problem hiding this comment.
Looks good!
Ready to merge to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug that allowed for additional properties in schemas using !ref