Skip to content

feat: hourly reminders and set alarm#11

Open
sanz17 wants to merge 10 commits intoIEEE-VIT:masterfrom
sanz17:master
Open

feat: hourly reminders and set alarm#11
sanz17 wants to merge 10 commits intoIEEE-VIT:masterfrom
sanz17:master

Conversation

@sanz17
Copy link
Copy Markdown

@sanz17 sanz17 commented Oct 2, 2021

closes #3

Copy link
Copy Markdown
Member

@mogiiee mogiiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the code is right.... the goal was to send reminders to the user after every half hour to check if they have completed the work.... but here a question is asked as soon as the work is given.

bot.py Outdated

msg = await client.wait_for("message", check=check)

while True:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is taking the bot into an infinite loop, make sure that does not happen.

@sanz17
Copy link
Copy Markdown
Author

sanz17 commented Oct 2, 2021

okay. i'll see to that

@sanz17 sanz17 changed the title feat: hourly reminders feat: hourly reminders and set alarm Oct 2, 2021
bot.py Outdated

if(diff>0):
{
msg=await ctx.send(f"Alarm is set for:{time}")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is putting off the code because it is not following a proper format of a dictionary .. please make sure it works properly

Copy link
Copy Markdown
Member

@mogiiee mogiiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this code working for you? It is being thrown into an error on line 82 for me... there are alot of indentations and syntax errors. I'd request you to work on those.

@sanz17
Copy link
Copy Markdown
Author

sanz17 commented Oct 2, 2021

please check only the last commit i made for fix: syntax and indentation errors for both alarm and hourly reminder....the other two
were done by mistake

@mogiiee
Copy link
Copy Markdown
Member

mogiiee commented Oct 2, 2021

@sanz17 there are alot of issues which are coming up when we are trying to start the bot and request the alarm ... please check it out. All the best.

@mogiiee
Copy link
Copy Markdown
Member

mogiiee commented Oct 5, 2021

@sanz17 I have reviewed your code thoroughly and these are the few improvements

  1. The bot is not reminding/asking the user after 30 minutes if they have finished their work.
  2. The bot is not asking the user even after 60 minutes are over whether they have finished the work or not .
  3. There are random capital words in the replies of the bot (which is not needed).

since you are working hard on this please use the command
'''
git clone https://github.com/IEEE-VIT/concy-bot.git
'''
and clone the repo again. You will find the daily-reminders function and get a rough estimate of how the bot is supposed to work for hourly reminders.
Another point to note is that make different PR's (pull requests) for

  • Alarm functionality
  • daily-reminders

You are almost there ... happy hacking. All the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hourly reminders

2 participants