Skip to content

Address feedbacks in DREF superticket feedbacks#1817

Merged
AdityaKhatri merged 5 commits intodevelopfrom
project/dref-superticket-2-feedbacks
May 12, 2025
Merged

Address feedbacks in DREF superticket feedbacks#1817
AdityaKhatri merged 5 commits intodevelopfrom
project/dref-superticket-2-feedbacks

Conversation

@frozenhelium
Copy link
Copy Markdown
Member

Addresses

Changes

  • Make end date of operation readonly field in all DREF forms
  • Fix font and spacing issues in the DREF exports (caused by link text overflow)
  • Update styling of Risk and Security Considerations section to match that of Previous Operations
  • Update visibility condition of National Society Actions in Final Report export

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • No console.log statements meant for debugging
  • All CI checks have passed

- DREF Application form
- DREF Operational Update form
- DREF Final Report form
fix the font size and spacing issues in the DREF exports
update styling of Risk and Security consideration to match styling of
  Previous Operations for all DREF exports
- update visibility condition of NS actionk
- hide description if the NS conducted any intervention is
  answered as `No`
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 12, 2025

🦋 Changeset detected

Latest commit: 9ed8181

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
go-web-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

valueType="text"
strongLabel
/>
{drefResponse?.has_national_society_conducted === true && (
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{drefResponse?.has_national_society_conducted === true && (
{!!drefResponse?.has_national_society_conducted && (

Copy link
Copy Markdown
Member Author

@frozenhelium frozenhelium May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdityaKhatri We are actually checking if the user has answered Yes

@AdityaKhatri AdityaKhatri merged commit bdc8543 into develop May 12, 2025
21 checks passed
@AdityaKhatri AdityaKhatri deleted the project/dref-superticket-2-feedbacks branch May 12, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants