DREF Imminent v2 Final Report#1942
Merged
AdityaKhatri merged 9 commits intodevelopfrom Aug 1, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 3ee9979 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shreeyash07
approved these changes
Jul 31, 2025
| headingLevel={3} | ||
| childrenContainerClassName={styles.proposedActions} | ||
| > | ||
| <div className={styles.actionTitleLabel} /> |
Collaborator
There was a problem hiding this comment.
Its empty. It is needed?
| {strings.priorityActionsBudget} | ||
| </div> | ||
| <div className={styles.actionTitleLabel}> | ||
| Expenditure |
| </div> | ||
| {proposedAction.actions.map((action) => ( | ||
| <Fragment key={action.id}> | ||
| {action.activities.map((activity, i) => ( |
Collaborator
There was a problem hiding this comment.
it would easier to read if we write index instead of i.
| (value: Maybe<number>) => ( | ||
| // FIXME: use translations | ||
| isDefined(value) && value !== SUB_TOTAL | ||
| ? 'The sub-total of the budgets should be exactly CHF 75000' |
Collaborator
There was a problem hiding this comment.
Use translation. do not forget to remove FIXME.
| const primarySectorOptions = usePrimarySector(); | ||
|
|
||
| const { | ||
| // pending: fetchingDref, |
Collaborator
There was a problem hiding this comment.
remove commented line it not needed
|
|
||
| const sortedPlannedInterventions = useMemo( | ||
| () => filteredPlannedIntervention?.sort( | ||
|
|
|
|
||
| const sortedIdentifiedNeedsAndGaps = useMemo( | ||
| () => filteredIdentifiedNeedsAndGaps?.sort( | ||
|
|
| <img | ||
| className={styles.icon} | ||
| src={identifiedNeed.image_url} | ||
| alt="" |
| <img | ||
| className={styles.icon} | ||
| src={plannedIntervention.image_url} | ||
| alt="" |
Comment on lines
+177
to
+185
| /* | ||
| if ((response.photos_file?.length ?? 0) > 0) { | ||
| response.photos_file?.forEach((img) => { | ||
| if (isDefined(img.file)) { | ||
| newMap[img.id] = img.file; | ||
| } | ||
| }); | ||
| } | ||
| */ |
Collaborator
There was a problem hiding this comment.
Remove commented or add Note
AdityaKhatri
approved these changes
Aug 1, 2025
frozenhelium
commented
Aug 1, 2025
Member
Author
There was a problem hiding this comment.
@barshathakuri @AdityaKhatri For future references, this should have been done using fixup commit! It wouldn't be possible to revert back to the moved migration!
* refactor(dref-export-modal): update pga state management logic
- use total_operation_timeframe_imminent in both form and export for imminent final report
AdityaKhatri
force-pushed
the
project/dref-imminent-v2-final-report
branch
from
1d0bccd to
3ee9979
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update final report form for dref imminent type
Addresses
Depends On
Changes
This PR Ensures:
console.logstatements meant for debugging