Update Local Units by frozenhelium · Pull Request #2206 · IFRCGo/go-web-app

frozenhelium · 2026-01-20T10:56:14Z

Addresses

Local Units - Properly handle switching between internally and externally managed states #2179

Depends on

Local Unit: Export feature and add validations checks go-api#2629

Changes

Refactor Local Units form
Add option to export Local Units
Add warning message in the Import Modal
Refactor Local Units Configuration Modal

changeset-bot · 2026-01-20T10:56:20Z

🦋 Changeset detected

Latest commit: 92b4a38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@ifrc-go/ui	Patch
go-web-app	Minor
go-ui-storybook	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

AdityaKhatri

Only checked logical issues. Haven't run it locally.

AdityaKhatri · 2026-01-21T05:58:38Z

+
+    const strings = useTranslation(i18n);
+    const [confirmationText, setConfirmationText] = useState<string>();
+    const [newValue, setNewValue] = useState(value);


Why is this required? I don't see a reason not to make this completely controlled.

The temporary state is to trigger the confirmation, actual value is synchronized with the server!

AdityaKhatri · 2026-01-21T06:01:12Z

+    const localUnitTypeToIdMap = listToMap(
+        externallyManagedResponse?.results,
+        ({ local_unit_type_details }) => local_unit_type_details.id,
+        ({ id }) => id,
+    );
+
+    const externallyManagedMapping = listToMap(
+        externallyManagedResponse?.results,
+        ({ local_unit_type_details }) => local_unit_type_details.id,
+        ({ enabled }) => enabled,
+    );


Preferably should be memoized

AdityaKhatri · 2026-01-21T06:17:45Z

+        },
+    });
+
+    const localUnitTypeLabelMap = listToMap(


preferably memoize

shreeyash07

Left few comments and please check again if any translation strings are missing. @frozenhelium

shreeyash07 · 2026-01-21T06:08:05Z

+                    value={selectedLocalUnitType}
+                    onChange={setSelectedLocalUnitType}
+                    name="local_unit_type"
+                    // disabled={pending}


if not needed remove this please check

@frozenhelium you missed this lets do it in next round

This will be taken care of during rebase

frozenhelium temporarily deployed to test January 20, 2026 10:56 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test January 20, 2026 10:57 — with GitHub Actions Inactive

frozenhelium force-pushed the project/local-units branch from a73b862 to e41b88c Compare January 20, 2026 10:59

frozenhelium temporarily deployed to test January 20, 2026 10:59 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test January 20, 2026 11:00 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test January 20, 2026 11:01 — with GitHub Actions Inactive

frozenhelium force-pushed the project/local-units branch from e41b88c to c7ed89c Compare January 21, 2026 05:17

frozenhelium temporarily deployed to test January 21, 2026 05:17 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test January 21, 2026 05:18 — with GitHub Actions Inactive

frozenhelium linked an issue Jan 21, 2026 that may be closed by this pull request

Local Units - Properly handle switching between internally and externally managed states #2179

Closed

frozenhelium temporarily deployed to test January 21, 2026 05:19 — with GitHub Actions Inactive

frozenhelium requested review from AdityaKhatri and shreeyash07 January 21, 2026 05:22

frozenhelium self-assigned this Jan 21, 2026

frozenhelium force-pushed the project/local-units branch from c7ed89c to e69bac1 Compare January 21, 2026 05:37

frozenhelium temporarily deployed to test January 21, 2026 05:37 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test January 21, 2026 05:38 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test January 21, 2026 05:39 — with GitHub Actions Inactive

AdityaKhatri reviewed Jan 21, 2026

View reviewed changes

shreeyash07 requested changes Jan 21, 2026

View reviewed changes

frozenhelium temporarily deployed to test January 21, 2026 08:05 — with GitHub Actions Inactive

frozenhelium requested review from AdityaKhatri and shreeyash07 January 21, 2026 08:05

frozenhelium temporarily deployed to test January 21, 2026 08:05 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test January 21, 2026 08:06 — with GitHub Actions Inactive

frozenhelium force-pushed the project/local-units branch from 5964b0b to e20a391 Compare January 21, 2026 08:10

frozenhelium temporarily deployed to test January 21, 2026 08:10 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test January 21, 2026 08:11 — with GitHub Actions Inactive

shreeyash07 approved these changes Jan 21, 2026

View reviewed changes

frozenhelium force-pushed the project/local-units branch from e20a391 to a510205 Compare January 21, 2026 11:45

frozenhelium temporarily deployed to test January 21, 2026 11:45 — with GitHub Actions Inactive

frozenhelium force-pushed the project/local-units branch from a510205 to eb83e4b Compare January 21, 2026 11:47

frozenhelium temporarily deployed to test January 21, 2026 11:47 — with GitHub Actions Inactive

frozenhelium force-pushed the project/local-units branch from eb83e4b to 46551be Compare January 21, 2026 11:54

frozenhelium temporarily deployed to test January 21, 2026 11:54 — with GitHub Actions Inactive

frozenhelium force-pushed the project/local-units branch from 46551be to 769d770 Compare January 22, 2026 03:26

frozenhelium temporarily deployed to test January 22, 2026 03:27 — with GitHub Actions Inactive

frozenhelium force-pushed the project/local-units branch from 769d770 to 78eb9ee Compare January 22, 2026 03:35

frozenhelium temporarily deployed to test January 22, 2026 03:35 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test January 22, 2026 05:05 — with GitHub Actions Inactive

frozenhelium force-pushed the project/local-units branch from 5d84977 to de93875 Compare January 22, 2026 05:06

chore(local-units): refactor and add export option

92b4a38

frozenhelium force-pushed the project/local-units branch from de93875 to 92b4a38 Compare January 22, 2026 08:59

frozenhelium merged commit 7e15227 into develop Jan 22, 2026
22 checks passed

frozenhelium deleted the project/local-units branch January 22, 2026 09:03

Conversation

frozenhelium commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Addresses

Depends on

Changes

Uh oh!

changeset-bot Bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

AdityaKhatri left a comment

Choose a reason for hiding this comment

Uh oh!

AdityaKhatri Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

frozenhelium Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

AdityaKhatri Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

AdityaKhatri Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

shreeyash07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shreeyash07 Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

shreeyash07 Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

frozenhelium Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

frozenhelium commented Jan 20, 2026 •

edited

Loading

changeset-bot Bot commented Jan 20, 2026 •

edited

Loading