Mantis #45000: ILIAS 10 - Show confirmation modal on contact unlink #10933
+129
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mBeym
force-pushed
the
feature/ilas10/contacts/unlink-confirmation-modal
branch
2 times, most recently
from
2167e74 to
9142c32
Compare
mjansenDatabay
added
bugfix
php
mjansenDatabay
requested changes
Jan 20, 2026
Contributor
mjansenDatabay
left a comment
mjansenDatabay
left a comment
There was a problem hiding this comment.
Thx @mBeym , I added some inline comments.
mBeym
force-pushed
the
feature/ilas10/contacts/unlink-confirmation-modal
branch
2 times, most recently
from
48d6b8e to
904df3b
Compare
components/ILIAS/Contact/BuddySystem/classes/class.ilBuddySystemGUI.php
Outdated
Show resolved
Hide resolved
mBeym
force-pushed
the
feature/ilas10/contacts/unlink-confirmation-modal
branch
2 times, most recently
from
57cba1f to
da496d1
Compare
mjansenDatabay
requested changes
Jan 21, 2026
mBeym
force-pushed
the
feature/ilas10/contacts/unlink-confirmation-modal
branch
3 times, most recently
from
97b0882 to
b70d18a
Compare
mBeym
changed the title
mBeym
force-pushed
the
feature/ilas10/contacts/unlink-confirmation-modal
branch
from
b70d18a to
172780b
Compare
mBeym
force-pushed
the
feature/ilas10/contacts/unlink-confirmation-modal
branch
from
172780b to
8802be4
Compare
|
|
||
| submitButton.addEventListener('click', (event) => { | ||
| event.preventDefault(); | ||
| global.jQuery(document).trigger(this.unlinkConfirmationModal.signals.close, {}); |
Contributor
There was a problem hiding this comment.
Please try:
Suggested change
| global.jQuery(document).trigger(this.unlinkConfirmationModal.signals.close, {}); | |
| this.unlinkModal.close(); |
| resolve(); | ||
| }, { signal: this.unlinkModalAbortController.signal }); | ||
|
|
||
| global.jQuery(document).trigger(this.unlinkConfirmationModal.signals.show, {}); |
Contributor
There was a problem hiding this comment.
Please try:
Suggested change
| global.jQuery(document).trigger(this.unlinkConfirmationModal.signals.show, {}); | |
| global.il.UI.modal.showModal( | |
| this.unlinkModal, | |
| {}, | |
| { | |
| id: this.unlinkConfirmationModal.modalId, | |
| }, | |
| this.unlinkConfirmationModal.signals.close | |
| ); |
Comment on lines
+106
to
+111
| $confirmation_modal = $this->ui_factory->modal()->interruptive( | ||
| $this->lng->txt('confirmation'), | ||
| $this->lng->txt('buddy_confirm_unlink'), | ||
| '' | ||
| ) | ||
| ->withActionButtonLabel($this->lng->txt('confirm')); |
Contributor
There was a problem hiding this comment.
Please try:
Suggested change
| $confirmation_modal = $this->ui_factory->modal()->interruptive( | |
| $this->lng->txt('confirmation'), | |
| $this->lng->txt('buddy_confirm_unlink'), | |
| '' | |
| ) | |
| ->withActionButtonLabel($this->lng->txt('confirm')); | |
| $modal_id = null; | |
| $confirmation_modal = $this | |
| ->ui_factory | |
| ->modal() | |
| ->interruptive( | |
| $this->lng->txt('confirmation'), | |
| $this->lng->txt('buddy_confirm_unlink'), | |
| '' | |
| ) | |
| ->withActionButtonLabel($this->lng->txt('confirm')) | |
| ->withAdditionalOnLoadCode(function ($id) use (&$modal_id) { | |
| $modal_id = $id; | |
| return ''; | |
| }); |
Comment on lines
+120
to
+121
| "close" => $confirmation_modal->getCloseSignal()->getId() | ||
| ] |
Contributor
There was a problem hiding this comment.
Please try:
Suggested change
| "close" => $confirmation_modal->getCloseSignal()->getId() | |
| ] | |
| "close" => $confirmation_modal->getCloseSignal()->getId() | |
| ], | |
| "modal_id" => $modal_id |
| this.unlinkModal = wrapper.querySelector('dialog'); | ||
| this.unlinkConfirmationModal.signals.show = data.signals.show; | ||
| this.unlinkConfirmationModal.signals.close = data.signals.close; | ||
| this.unlinkModalReady = true; |
Contributor
There was a problem hiding this comment.
Please try:
Suggested change
| this.unlinkModalReady = true; | |
| this.unlinkModalReady = true; | |
| this.unlinkConfirmationModal.modalId = data.modal_id; |
| }, | ||
| unlinkModalAbortController: null, | ||
| unlinkModal: null, | ||
| unlinkModalReady: false, |
Contributor
There was a problem hiding this comment.
Please try (maybe it should be name unlinkModalId if this all works):
Suggested change
| unlinkModalReady: false, | |
| unlinkModalReady: false, | |
| modalId: null, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://mantis.ilias.de/view.php?id=45000