Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes the HTTP-related factories through the dependency injection system by registering them in the
$implementmap during component initialization.Note: This change is only in
trunk(for now), but could be picked up in other branches if someone needs such a dependency in earlier versions.Motivation
This improves consistency with the DI architecture, enables easier substitution and testing, and avoids eager instantiation.
What changed
The following factories are now registered in the DI container:
CookieFactory→CookieFactoryImplCookieJarFactory→CookieJarFactoryImplRequestFactory→RequestFactoryImplResponseFactory→ResponseFactoryImplScope and impact