Skip to content

Conversation

@GitHamo
Copy link
Contributor

@GitHamo GitHamo commented Jan 21, 2026

This change exposes the HTTP-related factories through the dependency injection system by registering them in the $implement map during component initialization.

Note: This change is only in trunk (for now), but could be picked up in other branches if someone needs such a dependency in earlier versions.

Motivation

This improves consistency with the DI architecture, enables easier substitution and testing, and avoids eager instantiation.

What changed

The following factories are now registered in the DI container:

  • CookieFactoryCookieFactoryImpl
  • CookieJarFactoryCookieJarFactoryImpl
  • RequestFactoryRequestFactoryImpl
  • ResponseFactoryResponseFactoryImpl

Scope and impact

  • No behavioral changes to existing consumers.
  • No runtime logic added beyond DI registration.
  • Existing code can now depend directly on the factory interfaces via DI.

@GitHamo GitHamo requested a review from chfsx January 21, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant