Unexport LdapImpl.Config and expose via getter method#84
Merged
bosvos merged 1 commit intoldap-tests-asg-5028from Mar 7, 2026
Merged
Unexport LdapImpl.Config and expose via getter method#84bosvos merged 1 commit intoldap-tests-asg-5028from
LdapImpl.Config and expose via getter method#84bosvos merged 1 commit intoldap-tests-asg-5028from
Conversation
Copilot
AI
changed the title
[WIP] Fix LDAP debug logging and command line tool changes
Unexport Mar 7, 2026
LdapImpl.Config and expose via getter method
… tool Co-authored-by: bosvos <2437699+bosvos@users.noreply.github.com>
7abdf47 to
de361f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LdapImpl.Configwas exported, unintentionally widening the public API and allowing direct struct mutation. This replaces the exported field with an unexportedconfigand aGetConfig() *ConfigLDAPgetter.Changes
ldap.go:Config *ConfigLDAP→config *ConfigLDAPwithGetConfig() *ConfigLDAPgetter; all internal references updatedcmd/ldapfetch/main.go: Replaced struct literal initialization withNewAuthenticator_LDAP(ldapConf)constructor✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.