Add unit tests for extractPath, extractHierarchy, and printHierarchy#85
Merged
bosvos merged 1 commit intoldap-tests-asg-5028from Mar 7, 2026
Merged
Add unit tests for extractPath, extractHierarchy, and printHierarchy#85bosvos merged 1 commit intoldap-tests-asg-5028from
bosvos merged 1 commit intoldap-tests-asg-5028from
Conversation
Copilot
AI
changed the title
[WIP] Update LDAP debug logging and cmd line tool enhancements
Add unit tests for extractPath, extractHierarchy, and printHierarchy
Mar 7, 2026
Co-authored-by: bosvos <2437699+bosvos@users.noreply.github.com> PR #83 Changes
e43c5d4 to
1b70c1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractPath,extractHierarchy, andprintHierarchy(introduced in #83) had no test coverage despite non-trivial logic around DN parsing, tree construction, and conditional formatting.Tests added (
ldap_test.go)Test_extractPath— covers normal DNs, empty string, missing=, trailing=(empty value filtered),=inside value, and whitespace trimmingTest_extractHierarchy— covers emptySearchResult, single-entry tree construction, shared-ancestor deduplication across multiple entries, and malformed DN entriesTest_printHierarchy— covers nil-safe behaviour, slash-path for non-CN nodes, colon-path for CN nodes withprintNodesIfCN=true, and recursive child traversalExample of path extraction edge cases exercised:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.