chore: bump Chinlan and Kanade submodules to master - #38
Merged
Conversation
- Chinlan -> 6e3c214: project icon + README header - Kanade -> v0.1.2 (5ee8890): recipe loader fix + icon + docs Kanade v0.1.2 fixes the make ipa crash where verify_lc_load and patch_plist still had the old recipes.<name>-only loader logic and crashed with No module named 'recipes.recipes' on package-style --recipe recipes consumers like KEB. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s two Git submodules—Kanade (under shared/) and Chinlan (under Sources/Chinlan/)—to newer upstream commits. The intent is to pick up Kanade v0.1.2, which consolidates recipe loading into a shared implementation and resolves the reported load_recipe('recipes') import failure that previously blocked make ipa.
Changes:
- Bump Kanade submodule (
shared/) to v0.1.2 (5ee8890) to unblockmake ipavia the consolidated recipe loader. - Bump Chinlan submodule (
Sources/Chinlan/) to commit6e3c214(icon/README refresh upstream).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
shared |
Updates the Kanade submodule pointer to v0.1.2, which is expected to fix recipe loading used by the IPA pipeline. |
Sources/Chinlan |
Updates the Chinlan submodule pointer to the referenced upstream commit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
6e3c214: project icon + README header refresh5ee8890): recipe loader consolidation fix, project icon, decrypted-IPA explainerWhy
Kanade v0.1.2 contains the fix that unblocks
make ipa. The previous submodule bump (closed PR #33) pointed at the broken v0.1.1 where four recipe-consuming tools each had their own diverged_load_recipe, two of which still crashed with:v0.1.2 consolidates all four to a shared
tools.recipeload.load_recipeso the pipeline runs end-to-end.Test plan
load_recipe('recipes')resolves the KEB recipes package locally🤖 Generated with Claude Code