Conversation
…ng both playwright mcp and agent-browser cli
Automatically fetched and updated MCP server tool definitions. Generated at: 2026-02-18 06:40:49 UTC
…son and tools-fetch script
…/adk-ts into feat/add-popular-3p-mcps
Automatically fetched and updated MCP server tool definitions. Generated at: 2026-02-18 07:37:28 UTC
Replace hyphens in MCP tool names with underscores so they pass BaseTool validation, by adding sanitizeMcpToolName. Preserve the original MCP name in McpToolAdapter (originalMcpName) and use it for logging, client calls, handler calls, and error messages so calls back to the MCP server use the original identifier. Also ensure a fallback rawName is computed when name is missing.
…/adk-ts into feat/add-popular-3p-mcps
Automatically fetched and updated MCP server tool definitions. Generated at: 2026-02-18 09:06:21 UTC
…/adk-ts into feat/add-popular-3p-mcps
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Summary of ChangesHello @Rohit-KK15, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the ADK's integration capabilities by introducing dedicated wrapper functions for three popular third-party Model Context Protocol (MCP) servers: Playwright, Sequential Thinking, and Notion. It also enhances the documentation site's ability to display rich tool descriptions using Markdown and refines the tool naming convention to seamlessly handle hyphenated MCP tool names, improving compatibility and user experience. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds wrappers for three popular third-party MCP servers (Playwright, Sequential Thinking, and Notion), along with their documentation. It also fixes an issue with rendering multi-line markdown in tool descriptions and adds support for hyphenated tool names in MCP tools.
My review focuses on improving the maintainability of the new markdown rendering logic and fixing minor typos in the new example files. The core logic for supporting new MCPs and hyphenated names looks solid.
- In
apps/docs/components/mcp/mcp-tools-list.tsx, I've suggested replacing the custom markdown parser with a standard library to improve maintainability and robustness. - In
apps/examples/src/10-browser-automation/index.ts, I've pointed out a couple of typos in an example prompt.
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
@Royal-lobster Could you please review this PR when you get a momemt😅 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Add New third-party MCPs
@playwright/mcp, Sequential Thinking@modelcontextprotocol/server-sequential-thinking, and Notion@notionhq/notion-mcp-server<p>blockMCP Generic.Changes
packages/adk/src/tools/mcp/servers.tsMcpPlaywright()— wraps@playwright/mcpMcpSequentialThinking()— wraps@modelcontextprotocol/server-sequential-thinkingMcpNotion()— wraps@notionhq/notion-mcp-server, requiresNOTION_TOKENpackages/adk/src/tools/mcp/create-tool.tssanitizeMcpToolName()that replaces hyphens with underscores before the name hits BaseTool validationMcpToolAdapternow storesoriginalMcpNameseparately fromthis.nameoriginalMcpNameso the MCP server receives the name it expectsapps/docs/components/mcp/mcp-tools-list.tsxrenderDescription()that supports Markdown rendering for tool descriptions to improve structure and visual presentation.Docs
playwright.mdx,sequential-thinking.mdx,notion.mdxunderthird-party-wrappers/McpGenericusage documented inthird-party-wrappers/index.mdxandexternal-mcps.mdxfetch-mcp-tools.tsupdated to include playwright, sequential-thinking, and notion entriesCloses: #589, #590, #591