Improve MCP sampling documentation for clarity and consistency#598
Improve MCP sampling documentation for clarity and consistency#598
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Summary of ChangesHello @Timonwa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation for MCP sampling within the ADK-TS framework. The changes focus on improving clarity, consistency, and providing more practical guidance for users. It updates terminology, clarifies core concepts, and introduces new sections and examples to help users better understand and implement custom sampling handlers and architectural patterns. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly improves the documentation for MCP Sampling. The content has been thoughtfully restructured for better logical flow, and the explanations are much clearer and more concise. The updated code examples are more practical and demonstrate best practices effectively. Key improvements include the new sections on honouring model preferences and managing the handler at runtime, which add a lot of value for developers. Overall, this is an excellent documentation update that greatly enhances clarity and usability.
MarvelNwachukwu
left a comment
There was a problem hiding this comment.
Missed this, looks good
Pull Request
Description
Enhance the documentation for MCP sampling to ensure clarity and consistency throughout the content. This update aims to provide better guidance for users.
Related Issue
Type of Change
How Has This Been Tested?
Closes #593
Checklist
Screenshots (if applicable)
Additional Notes
I removed the API Reference section, cos we already have an API Reference doc. they can get the information there..