You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks a lot for this, @mega123-art — you diagnosed a real crash precisely. ownedSkills() returns a string[], so c.send({ type: "ownedSkills", ...r }) spread the array into {0:..,1:..}, dropping names and leaving marketOwned undefined — which blew up the reducer (the mobile market black screen). Spot on. 🙏
The reason I'm closing rather than merging: the exact same fix already landed on main in commit 3b6b601 ("Fix mobile market RPC setup"), on both sides:
server: ownedSkills now sends { names: await mkt.ownedNftSkills(), mints, disposedMints } instead of spreading
it would revert the attachMarketHandlers extraction (which also makes the market reachable from the onboarding/storage client)
So your fix is effectively already in — closing as already incorporated, with credit to you for catching it. Really appreciate the sharp eye, and please keep them coming! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
This targets the mobile market black-screen crash path when entering the market.