Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the metrics middleware to record the route using req.route instead of req.path.
- Replaced req.path with req.route in metrics calls for better route tracking.
Comments suppressed due to low confidence (2)
src/main.ts:42
- Switching from req.path to req.route may yield an object rather than the expected string for metrics. If a string representation is required, consider using req.route.path or converting the object accordingly.
end({ method: req.method, route: req.route, status: res.statusCode.toString() });
src/main.ts:43
- Switching from req.path to req.route may yield an object rather than the expected string for metrics. If a string representation is required, consider using req.route.path or converting the object accordingly.
requestCounter.inc({ method: req.method, route: req.route, status: res.statusCode.toString() });
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Manuel-Pol
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.