Support TensorAlgebra 0.16#202
Merged
Merged
Conversation
mtfishman
force-pushed
the
mf/unmatricize-domain-convention
branch
from
43da223 to
84581fd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 81.86% 81.86%
=======================================
Files 23 23
Lines 1864 1864
=======================================
Hits 1526 1526
Misses 338 338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mtfishman
force-pushed
the
mf/unmatricize-domain-convention
branch
from
84581fd to
1d9f3b1
Compare
Adapts the `SectorFusion` `unmatricize` overloads to TensorAlgebra 0.16 (ITensor/TensorAlgebra.jl#199), which takes `unmatricize` domain axes codomain-facing (un-dualized). The terminal overloads re-dualize the domain axes with `conj` before reconstructing the graded array, and the round-trip tests pass their domain axes un-dualized to match. - [ ] Remove the `[sources]` pins on `TensorAlgebra` and `SparseArraysBase` once both register
mtfishman
force-pushed
the
mf/unmatricize-domain-convention
branch
from
1d9f3b1 to
83d4b81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adapts the
SectorFusionunmatricizeoverloads to TensorAlgebra 0.16 (ITensor/TensorAlgebra.jl#199), which takesunmatricizedomain axes codomain-facing (un-dualized). The terminal overloads re-dualize the domain axes withconjbefore reconstructing the graded array, and the round-trip tests pass their domain axes un-dualized to match.