[WIP] Matrix factorizations, *, and one! for AbelianGradedMatrix#208
Draft
mtfishman wants to merge 1 commit into
Draft
[WIP] Matrix factorizations, *, and one! for AbelianGradedMatrix#208mtfishman wants to merge 1 commit into
mtfishman wants to merge 1 commit into
Conversation
Route the matrix-level linear algebra for a bare `AbelianGradedMatrix` through the matricizing `TensorAlgebra` factorizations: the `MatrixAlgebraKit` factorization family, `Base.:*`, and in-place `one!`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 80.37% 76.08% -4.30%
==========================================
Files 24 23 -1
Lines 1957 1961 +4
==========================================
- Hits 1573 1492 -81
- Misses 384 469 +85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fill in the matrix-level linear algebra for a bare
AbelianGradedMatrixby routing through the matricizingTensorAlgebrafactorizations.The
MatrixAlgebraKitfactorizations (svd_compact,svd_full,svd_vals,qr_compact,qr_full,lq_compact,lq_full,eig_full,eig_vals,eigh_full,eigh_vals,left_polar,right_polar,project_hermitian) now accept a bareAbelianGradedMatrix: each matricizes to aFusedGradedMatrix, runs the block factorization, and unmatricizes the factors back. Only the functions with an identically-namedTensorAlgebraperm-form are covered here.Base.:*on twoAbelianGradedMatrixes is defined in terms ofcontract, which matricizes internally.MatrixAlgebraKit.one!fills anAbelianGradedMatrixwith the graded identity in place, delegating toTensorAlgebra.one!(added in ITensor/TensorAlgebra.jl#205).TODO
TensorAlgebra[sources]pin once [WIP] Add datatype, in-place one!/unmatricize!, make scalar/similar_map public TensorAlgebra.jl#205 registers as0.17.1.