Stop exporting names that shadow Base, LinearAlgebra, or ITensorBase#3
Merged
Conversation
Names this compat layer owns but that share a name with a `Base`, `LinearAlgebra`, or `ITensorBase` function (`exp`, the `svd`/`qr`/`eigen`/`factorize` factorizations, and `inds`/`prime`/`noprime`/`apply`/`state`) are no longer exported. They stay defined and are reached qualified, e.g. `ITensors.svd`, matching how `tr` was already handled. This avoids a name collision when a consumer has one of those packages in scope alongside this one. Everything else is still exported for `using ITensorsITensorBaseCompat.ITensors`.
The `test/`, `docs/`, and `examples/` projects pin the package version, so move their `[compat]` entries to `0.2` alongside the breaking version bump.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=====================================
Coverage 1.96% 1.96%
=====================================
Files 5 5
Lines 306 306
=====================================
Hits 6 6
Misses 300 300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Names this compat layer owns but that share a name with a
Base,LinearAlgebra, orITensorBasefunction (exp, thesvd/qr/eigen/factorizefactorizations, andinds/prime/noprime/apply/state) are no longer exported. They stay defined and are reached qualified, e.g.ITensors.svd, matching howtrwas already handled. This avoids a name collision when a consumer has one of those packages in scope alongside this one. Everything else is still exported forusing ITensorsITensorBaseCompat.ITensors.Removing exports is breaking, so this bumps the version to
0.2.0.