[WIP] Route concatenation and zero! through TensorAlgebra#191
Draft
mtfishman wants to merge 1 commit into
Draft
Conversation
## Summary `concatenate`/`cat` and `zero!` now come from TensorAlgebra rather than being owned locally. The vendored `Concatenate` module is removed, and `Base._cat` on sparse arrays routes through `TensorAlgebra.concatenate`. The sparse `zero!` methods extend `TensorAlgebra.zero!`, and SparseArraysBase's identical dense fallback is dropped in favor of TensorAlgebra's. TensorAlgebra becomes a regular dependency, so the `SparseArraysBaseTensorAlgebraExt` extension is folded into `src/tensoralgebra.jl`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 task
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 77.45% 68.26% -9.20%
==========================================
Files 12 10 -2
Lines 896 753 -143
==========================================
- Hits 694 514 -180
- Misses 202 239 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the vendored
Concatenateinterface now that it lives in TensorAlgebra (ITensor/TensorAlgebra.jl#210), and extends that interface for sparse storage there instead.zero!is routed through TensorAlgebra the same way: the sparse array types extendTensorAlgebra.zero!to empty their storage in place rather than filling it with zeros.TODO
TensorAlgebra[sources]pin and confirm the compat floor once TensorAlgebra 0.17.5 registers.