Skip to content

Make sure Create_INChI always deallocates t_group#202

Closed
nazavode wants to merge 1 commit intoIUPAC-InChI:devfrom
nazavode:dev
Closed

Make sure Create_INChI always deallocates t_group#202
nazavode wants to merge 1 commit intoIUPAC-InChI:devfrom
nazavode:dev

Conversation

@nazavode
Copy link

@nazavode nazavode commented Mar 2, 2026

This PR adds deallocation of t_group to a Create_INChI path where it was missing.

Fixes #201

Note: this commented call would fix this issue as well, but I'm assuming that should stay commented.

@djb-rwth djb-rwth self-assigned this Mar 2, 2026
@djb-rwth
Copy link
Collaborator

djb-rwth commented Mar 2, 2026

Hi @nazavode,
As can be seen from the checks in this PR, and referring to my response in GHI #201, this cannot be fixed in the way proposed here without affecting the functionality of InChI.
Sadly, it requires a lot more work.

@djb-rwth djb-rwth closed this Mar 2, 2026
@nazavode
Copy link
Author

nazavode commented Mar 2, 2026

I see, thanks anyway @djb-rwth for looking into this.

@djb-rwth
Copy link
Collaborator

djb-rwth commented Mar 2, 2026

Hi @nazavode,

I see, thanks anyway @djb-rwth for looking into this.

No problems and thank you for creating this PR and issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory leak in Create_INChI

2 participants