Skip to content

src/lib/rinchi_hashing: Correct comment about structure of 17-char hash #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janholstjensen merged 1 commit into from
Feb 9, 2026
Merged

src/lib/rinchi_hashing: Correct comment about structure of 17-char hash #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/rinchi_hashing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ std::string hash17char(const std::string& input)
result += base26_triplet_3(chksum);
result += base26_triplet_4(chksum);
result += base26_dublet_for_bits_56_to_64(chksum);
// chksum[8] = bits 65->...
// chksum[8] = bits 64.. (bit 64 is used twice)
result += base26_triplet_1(&chksum[8]);
#ifdef RINCHI_DEBUG_OUTPUT_HASHING
std::cout << "[#17[" << input << "]#] => " << result << std::endl;
Expand All @@ -157,3 +157,4 @@ const std::string HASH_14_EMPTY_STRING = "UHFFFADPSCTJAU";
const std::string HASH_17_EMPTY_STRING = "UHFFFADPSCTJAUYIS";

} // end of namespace

Copy link
Contributor Author

@Artoria2e5 Artoria2e5 Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like GitHub web editor does not like NOEOL.

Loading