Skip to content

feat(tls): adjusting to consider the same connection in others sales #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arthurkolankiewicz-alt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(tls): adjusting to consider the same connection in others sales #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/Soap/SoapBase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,9 +524,20 @@ public function saveTemporarilyKeyFiles()
//clear dir cert
$this->removeTemporarilyFiles();
$this->certsdir = 'certs/';
$this->prifile = $this->randomName();
$this->pubfile = $this->randomName();
$this->certfile = $this->randomName();
// nomes deterministicos por certificado: mesmo cert => mesmo path.
// necessario para que o curl reaproveite a conexao TLS do pool
// (CURLOPT_SHARE), evitando refazer o handshake a cada documento.
// so e seguro com chave nao-encriptada (temppass vazio), que e o padrao.
if (! $this->encriptPrivateKey) {
$hash = sha1((string) $this->certificate->publicKey);
$this->prifile = $this->certsdir . $hash . '_pri.pem';
$this->pubfile = $this->certsdir . $hash . '_pub.pem';
$this->certfile = $this->certsdir . $hash . '_cert.pem';
} else {
$this->prifile = $this->randomName();
$this->pubfile = $this->randomName();
$this->certfile = $this->randomName();
}
$ret = true;
//load private key pem
$private = $this->certificate->privateKey;
Expand Down
47 changes: 43 additions & 4 deletions src/Soap/SoapCurl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,34 @@
namespace NFePHP\Common\Soap;

use CurlHandle;
use NFePHP\Common\Soap\SoapBase;
use NFePHP\Common\Soap\SoapInterface;
use NFePHP\Common\Exception\SoapException;
use NFePHP\Common\Validator;
use NFePHP\Common\Certificate;

class SoapCurl extends SoapBase implements SoapInterface
{
/**
* Handle cURL persistente, nivel-processo. Mantido vivo entre instancias
* de SoapCurl (cada documento cria uma nova) para reaproveitar a conexao
* TCP/TLS e evitar refazer o handshake (~2.3s) a cada requisicao.
* Funciona em qualquer versao de PHP (nao depende de CURL_LOCK_DATA_CONNECT).
* @var CurlHandle|resource|null
*/
private static $persistentCurl = null;

/**
* Timestamp (epoch) do ultimo uso do handle persistente.
* @var int
*/
private static $lastUsedAt = 0;

/**
* Segundos de ociosidade apos os quais o handle e descartado e a conexao
* refeita (o SVRS fecha conexoes ociosas; reusar um socket morto causaria
* reset by peer). 30s.
*/
private const IDLE_LIMIT = 30;

/**
* Constructor
* @param Certificate $certificate
Expand Down Expand Up @@ -77,14 +97,27 @@ public function send(
$this->requestHead = implode("\n", $parameters);
$this->requestBody = $envelope;
try {
$oCurl = curl_init();
// reutiliza o handle persistente do processo (mantem a conexao viva).
// se ficou ocioso demais, descarta para reconectar (evita socket morto).
if (self::$persistentCurl !== null
&& (time() - self::$lastUsedAt) > self::IDLE_LIMIT
) {
curl_close(self::$persistentCurl);
self::$persistentCurl = null;
}
if (self::$persistentCurl === null) {
self::$persistentCurl = curl_init();
}
$oCurl = self::$persistentCurl;
$this->setCurlProxy($oCurl);
curl_setopt($oCurl, CURLOPT_URL, $url);
curl_setopt($oCurl, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4);
curl_setopt($oCurl, CURLOPT_CONNECTTIMEOUT, $this->soaptimeout);
curl_setopt($oCurl, CURLOPT_TIMEOUT, $this->soaptimeout + 20);
curl_setopt($oCurl, CURLOPT_HEADER, 1);
curl_setopt($oCurl, CURLOPT_HTTP_VERSION, $this->httpver);
// keep-alive ativo para manter a conexao ociosa aberta entre documentos
curl_setopt($oCurl, CURLOPT_TCP_KEEPALIVE, 1);
curl_setopt($oCurl, CURLOPT_SSL_VERIFYHOST, 0);
curl_setopt($oCurl, CURLOPT_SSL_VERIFYPEER, 0);
if (!empty($this->security_level)) {
Expand All @@ -111,6 +144,7 @@ public function send(
curl_setopt($oCurl, CURLOPT_HTTPHEADER, $parameters);
}
$response = curl_exec($oCurl);
self::$lastUsedAt = time();
$this->soaperror = curl_error($oCurl);
$this->soaperror_code = curl_errno($oCurl);
$ainfo = curl_getinfo($oCurl);
Expand All @@ -119,7 +153,12 @@ public function send(
}
$headsize = curl_getinfo($oCurl, CURLINFO_HEADER_SIZE);
$httpcode = curl_getinfo($oCurl, CURLINFO_HTTP_CODE);
curl_close($oCurl);
// NAO fechar o handle: mantem a conexao TCP/TLS no pool para o proximo documento.
// em erro de transporte, descarta o handle para forcar reconexao limpa.
if ($this->soaperror_code !== 0) {
curl_close($oCurl);
self::$persistentCurl = null;
}
$this->responseHead = trim(substr($response, 0, $headsize));
$this->responseBody = trim(substr($response, $headsize));
$this->saveDebugFiles(
Expand Down