Actually unloading VRAM when the logger claims to do so.#2
Open
Erquint wants to merge 1 commit intoIceFog72:mainfrom
Open
Actually unloading VRAM when the logger claims to do so.#2Erquint wants to merge 1 commit intoIceFog72:mainfrom
Erquint wants to merge 1 commit intoIceFog72:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug this fixes is that VRAM remains occupied when switching to CPU.
Now calling
torch.cuda.empty_cache()when🔄 Moving model back to CPUis printed.Conditionals rearranged accordingly for call safety.
It could be argued that preserving the model cached in VRAM for some time is a benefit for a multi-user environment, but that would need to be handled and parametrized in the config.