chore(deps): bump postgres from 17 to 18 in the compose-images group#284
Open
dependabot[bot] wants to merge 1 commit into
Open
chore(deps): bump postgres from 17 to 18 in the compose-images group#284dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the compose-images group with 1 update: postgres. Updates `postgres` from 17 to 18 --- updated-dependencies: - dependency-name: postgres dependency-version: '18' dependency-type: direct:production update-type: version-update:semver-major dependency-group: compose-images ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
IcebergAutoReview
Verdict: request_changes
The PostgreSQL 18 major upgrade is incomplete and can prevent Compose deployments from starting or persisting data correctly.
Findings
- Blocking — docker-compose.yml still mounts
iceberg-pg-dataat/var/lib/postgresql/data. PostgreSQL 18 changedPGDATAto/var/lib/postgresql/18/dockerand requires the volume at/var/lib/postgresql; the official entrypoint detects the old mount and can reject startup. Existing PostgreSQL 17 clusters also require an explicit pg_upgrade or dump/restore migration, which this PR neither implements nor documents. Update the mount, provide a safe upgrade procedure, and add a persistence/startup regression check. Official guidance: https://github.com/docker-library/docs/blob/master/postgres/README.md#pgdata
Validation
- Inspected the complete
main...HEADdiff and commit ancestry; only the Compose image tag changed. - Reviewed Compose volume configuration, backup documentation, PostgreSQL CI services, and focused Compose configuration test.
- Verified from the official PostgreSQL image documentation and image metadata that PostgreSQL 18 uses
PGDATA=/var/lib/postgresql/18/dockerandVOLUME /var/lib/postgresql. - Attempted a local image inspection, but Docker is not installed in the review environment; no container was pulled or started.
Residual risks / optional notes
- PR CI does not exercise PostgreSQL 18: both PostgreSQL smoke services remain on version 17, and the Docker/Compose-related jobs are skipped for pull requests.
- README architecture diagrams still describe
postgres:17and the obsolete/var/lib/postgresql/datavolume layout.
Automated review by Codex 3f1a5ed4c0c4 using IcebergAutoReview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the compose-images group with 1 update: postgres.
Updates
postgresfrom 17 to 18Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions