Enhance severity icons - #499
Merged
Merged
Conversation
sukhwinder33445
force-pushed
the
enhance-severity-icons
branch
from
June 17, 2026 15:02
5db1229 to
747c8db
Compare
nilmerg
requested changes
Jun 23, 2026
sukhwinder33445
force-pushed
the
enhance-severity-icons
branch
2 times, most recently
from
June 24, 2026 19:05
11b1168 to
a8e02f5
Compare
sukhwinder33445
force-pushed
the
enhance-severity-icons
branch
2 times, most recently
from
June 25, 2026 07:00
1c9a0d7 to
f5279e7
Compare
sukhwinder33445
force-pushed
the
enhance-severity-icons
branch
3 times, most recently
from
June 25, 2026 08:43
d20b25f to
5948efc
Compare
sukhwinder33445
force-pushed
the
enhance-severity-icons
branch
from
June 26, 2026 09:51
5948efc to
0f0c798
Compare
nilmerg
approved these changes
Jun 26, 2026
- Extend the severity icon condition to support more severity types. - Replace the single-use method with a direct match expression. - Add a title attribute to the icons. `Icons`:Replace unused icon `heart` with `circle-check` (already in use)
Severity logic (icons, labels, values) was scattered across `Icons.php`, `IncidentRenderer`, `IncidentHistoryRenderer`, and `EscalationCondition` as hardcoded strings and match expressions. A new `Severity` enum consolidates this, and a `EnumCast` ipl-orm behavior automatically converts DB strings to typed enum values, replacing all string comparisons with type-safe enum references.
sukhwinder33445
force-pushed
the
enhance-severity-icons
branch
from
July 15, 2026 19:36
0f0c798 to
6cd5b5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a Severity backed enum that centralises all severity logic — backing values, translated labels, and icons — in one place, replacing scattered string constants in Icons and inline match expressions in the renderers. Wires up EnumCast on Incident and IncidentHistory so the severity column is hydrated directly as a Severity instance, turning raw string comparisons like
$item->severity === 'ok'into type-safe$item->severity === Severity::OK. Also updates theSEVERITY_OKicon fromhearttocircle-checkfor visual consistency with the other severity levels.resolves #479
require Icinga/ipl-orm#162