CheckTimeSync: Let "IgnoreService" truly ignore the local service#422
Open
RincewindsHat wants to merge 2 commits intomasterfrom
Open
CheckTimeSync: Let "IgnoreService" truly ignore the local service#422RincewindsHat wants to merge 2 commits intomasterfrom
RincewindsHat wants to merge 2 commits intomasterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lorenz Kästle.
|
82af87e to
2a1e5f3
Compare
|
We have tested the solution in our company and the result meets the expectations of the “IgnoreService” function. A quick implementation and release would be nice from our point of view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the "-IgnoreService" flag did only prevent the specific
IcingaCheckfrom becomingCRITICAL(which does not prevent it from becomingUNKNOWN!).This does not really fit the definition of "ignore" in my book.
This commit changes the behaviour to completely ignore it, when the flag is set.