Ensure forward compatibility with ipl-orm by adding return types#1340
Merged
Conversation
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
March 2, 2026 14:22
0a29944 to
622bed8
Compare
BastianLedererIcinga
force-pushed
the
modernize-code
branch
3 times, most recently
from
March 4, 2026 12:56
cd3dd85 to
d8a9fdb
Compare
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
March 6, 2026 09:16
d8a9fdb to
cb75027
Compare
sukhwinder33445
previously approved these changes
Mar 6, 2026
BastianLedererIcinga
force-pushed
the
modernize-code
branch
3 times, most recently
from
March 9, 2026 12:29
1981131 to
b38a396
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
March 9, 2026 13:07
a42d158 to
05a46a9
Compare
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
March 9, 2026 13:09
b38a396 to
5808d29
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
2 times, most recently
from
March 10, 2026 09:19
49d97b4 to
3caa773
Compare
17 tasks
lippserd
force-pushed
the
support-php-8.4/8.5
branch
from
March 19, 2026 21:08
3caa773 to
a99b2ec
Compare
lippserd
changed the title
ipl-orm by aligning return types
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
3 times, most recently
from
March 20, 2026 10:54
76f5d63 to
d360924
Compare
lippserd
force-pushed
the
support-php-8.4/8.5
branch
from
March 20, 2026 13:54
d360924 to
5053fb3
Compare
Add explicit return types to `ipl-orm`-derived methods to prepare for strict typing. These additions are safe, as they only annotate existing methods that previously lacked return type declarations.
lippserd
changed the title
ipl-orm by aligning return typesipl-orm by adding return types
lippserd
force-pushed
the
modernize-code
branch
from
March 20, 2026 15:28
5808d29 to
0c4aab1
Compare
lippserd
reviewed
Mar 20, 2026
lippserd
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit return types to
ipl-orm-derived methods to prepare for stricttyping. These additions are safe, as they only annotate existing methods that
previously lacked return type declarations.
refs Icinga/ipl-orm#158