Skip to content

Fix superfluous subquery filters#131

Draft
nilmerg wants to merge 10 commits into
mainfrom
fix/superfluous-subquery-filters-119
Draft

Fix superfluous subquery filters#131
nilmerg wants to merge 10 commits into
mainfrom
fix/superfluous-subquery-filters-119

Conversation

@nilmerg

@nilmerg nilmerg commented Feb 22, 2024

Copy link
Copy Markdown
Member

fixes #119

@nilmerg nilmerg added the bug Something isn't working label Feb 22, 2024
@nilmerg nilmerg added this to the v0.6.1 milestone Feb 22, 2024
@nilmerg nilmerg self-assigned this Feb 22, 2024
@cla-bot cla-bot Bot added the cla/signed label Feb 22, 2024
@nilmerg
nilmerg force-pushed the fix/superfluous-subquery-filters-119 branch 12 times, most recently from f8b14ce to aac5e2a Compare February 28, 2024 13:52
@nilmerg
nilmerg requested a review from lippserd February 28, 2024 13:54
@nilmerg
nilmerg force-pushed the fix/superfluous-subquery-filters-119 branch from 8abd7c8 to 1860a4f Compare February 28, 2024 15:24
@nilmerg
nilmerg force-pushed the fix/superfluous-subquery-filters-119 branch from 76ecc85 to f57e2ad Compare March 12, 2024 16:04
@nilmerg
nilmerg changed the base branch from main to fix/sql-null-oddities March 12, 2024 16:05
Base automatically changed from fix/sql-null-oddities to main March 22, 2024 13:46
@nilmerg nilmerg removed this from the v0.6.1 milestone Mar 26, 2024
@nilmerg
nilmerg force-pushed the fix/superfluous-subquery-filters-119 branch from f57e2ad to 8ed9ed7 Compare March 26, 2024 16:01
@nilmerg

nilmerg commented May 15, 2024

Copy link
Copy Markdown
Member Author

The case a:multiple, b:AND, c:single, d:same, e:different might have covered Icinga/icingadb-web#1022, but since the second condition is an Unequal, it doesn't, as such cause different behavior anyway.

@nilmerg
nilmerg force-pushed the fix/superfluous-subquery-filters-119 branch from 8ed9ed7 to e2d534a Compare February 17, 2026 09:32
@nilmerg
nilmerg force-pushed the fix/superfluous-subquery-filters-119 branch from 01c2375 to 7cc821a Compare July 22, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lippserd lippserd Awaiting requested review from lippserd

At least 1 approving review is required to merge this pull request.

Assignees

@nilmerg nilmerg

Labels

bug Something isn't working cla/signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apply subquery filters of the same relation correctly

1 participant

@nilmerg