Open
Conversation
kornel-filep
commented
Aug 11, 2020
| it('should return negative value when negative number', () => expect(calc(-3).v).equal(-3)) | ||
| }) | ||
| describe('add', () => { | ||
| it('should return 8 when adding 3 and 5', () => expect(calc(3).add(5).v).equal(8)) |
Author
There was a problem hiding this comment.
I skipped the.to.be part to minimize unnecessary boilerplate code, cause here the .to.be would not really increase readability.
Is it a bad practice? How is it used more in practice? (skipped or the .to.be and similar chain getters are just always there?)
Collaborator
There was a problem hiding this comment.
However, skipping the fillers does not affect the assertion itself, but still, in practice, we use them to be a bit more human-like and easy to adopt.
In some simple cases, this is not too talkative at all, but from a consistency perspective, I would suggest to use them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.