fix: preserve terminal failures when result publication fails - #75
Merged
Conversation
Member
|
검토하고 병합합니다. 요청한 두 가지가 정확히 들어갔습니다 — 발행 실패를 삼키고 원래 루트 쪽과 맞물리는 것도 확인했습니다. user-data 가 공급하는 파생 UUID 가 이 저장소는 원래 같은 릴리스에 backend #250(체크섬 handoff)과 루트 user-data UUID 수정을 함께 올립니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
JobNotSatisfiabledecision and its original reason code when publishing the failure event itself raisesHANDLER_ERROR:*and retryBACKTEST_WORKER_CORRELATION_IDas a UUID before building any other production worker dependencyRoot cause
A malformed worker correlation ID caused terminal failure-event construction to raise. That secondary exception escaped
OrchestratorJobHandler, so the outer worker classified it as a retryable handler error and hid the originalREQUIRED_INPUT_UNAVAILABLEdecision.Impact
Terminal binding failures now remain permanent even when their result event cannot be published, and their original reason survives in worker attempt/DLQ handling. Invalid correlation IDs fail at process startup instead of remaining latent until the first result event.
This PR changes only backtest-engine. The backend compiled-plan handoff and root user-data UUID generation remain separately owned and are not modified here.
TDD evidence
Before implementation, the three new regression tests failed with:
OSError: result sink unavailableescaping the handler_required_uuidconfiguration validatorAfter implementation:
python -m ruff check src tests— passedpython -m mypy— passed, 74 source filespython -m pytest tests/test_wiring.py tests/test_production.py tests/test_worker.py -q— passed, 61 testspython -m pytest -p no:cacheprovider -m "not docker"— 1240 passed, 3 skipped, 168 deselectedgit diff --check— passedNo AWS run, release, DLQ operation, worker restart, ASG operation, or database mutation was performed.
Closes #74