Fix legacy dataset manifest binding and retry loop - #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
INT03 run
dcc110d7-6cb2-3909-bb9f-623b21ac90bfselected AVAILABLE manifest7f7113c9-3b02-4098-97ec-0baa07e2b3b0. Its eight deployed object keys use the legacy loader path segmentmanifest_id=<UUID>, whilePostgresDatasetManifestSourceaccepted only the newerdataset=<UUID>convention. The resultingConfigurationErrorescaped the handler and the worker retried the same deterministic input five times.Fix
dataset=<UUID>keys only when every object binds one identical logical dataset;manifest_id=<UUID>keys only when every object binds the requested manifest;JobNotSatisfiable(REQUIRED_INPUT_UNAVAILABLE), which the existing handler publishes as a non-retryable terminal FAILED result;Verification
python -m pytest -p no:cacheprovider tests/test_production.py -k dataset_manifest_source -q— 6 passedpython -m pytest -p no:cacheprovider— 1245 passed, 3 skipped, 168 deselectedpython -m ruff check src tests— passedpython -m mypy— passedgit diff --check— passedNo schema, contract, DLQ, worker, ASG, or database mutations are included.
Closes #76