fix: terminate incompatible compiled plans - #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78.
AWS Development cause
INT03 run
66956d2d-1e21-37e9-bd62-a510f248a239received an immutable compiled plan whoseexecutionSnapshot.initialCashAmountwas100000instead of the contract-required fixed-scale100000.00000000.BasicPlanRuntime.loadcorrectly raisedBasicPlanCompatibilityError(PLAN_CONTRACT_INVALID), but the production binding let it escape to the worker's generic exception handler, which returned the same SQS message five times asHANDLER_ERROR:BasicPlanCompatibilityError.The Backend producer normalization fix is separately tracked in Idea2Strategy-backend#255. This PR deliberately does not relax the compiled-plan contract.
Fix
Translate any deterministic
BasicPlanCompatibilityErrorat the immutable plan binding boundary intoJobNotSatisfiable, preserving the exactPlanLoadFailurereason. The existing terminal publication path now emits oneFAILED,retryable=falseevent and returnsPERMANENT_FAILURE.Regression
The test injects the exact observed scale-less
100000plan field and proves:PLAN_CONTRACT_INVALIDretryable=falseVerification
git diff --checkpassed