Skip to content

Fix official backtests without feature pins #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjy008008 merged 1 commit into from
Aug 9, 2026
Merged

Fix official backtests without feature pins #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/backtest_engine/schemas/strategy-bot/v1/official-backtest-request.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
"requestReason": {"const": "STRATEGY_RELEASE"},
"featureMaterializations": {
"type": "array",
"minItems": 1,
"items": {
"type": "object",
"required": ["featureMaterializationId", "lockedResultHash"],
Expand Down
10 changes: 10 additions & 0 deletions tests/test_contracts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,16 @@ def test_consumer_accepts_bs_official_backtest_request_verbatim(
assert accepted["datasetManifestId"] == B_DATASET_MANIFEST_ID


def test_official_request_accepts_no_feature_materializations(
official_request: dict[str, Any],
) -> None:
official_request["featureMaterializations"] = []

accepted = validate_official_backtest_request(official_request)

assert accepted["featureMaterializations"] == []


def test_official_request_identity_covers_every_server_selected_dataset(
official_request: dict[str, Any],
) -> None:
Expand Down