fix: guard feature backfill catalog access - #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PostgresCatalog.connectStorageObjectsPolicy.READ_ONLYfor the plannerWhy
The deployed
backfill_featuresentry point still constructedPostgresCatalogwith the old signature. After storage ownership became explicit, the read-only planning command failed before reading the development catalog:TypeError: PostgresCatalog.__init__() missing 1 required keyword-only argument: 'storage_objects'Using the guarded factory also keeps the operator planner from receiving storage-object write authority it does not need.
Impact
The §2.5 operator can once again inspect the four-resolution RSI backfill plan before sending any SQS commands. No schema, migration, or feature calculation behavior changes.
Validation
pytest tests/test_feature_backfill.py -q: 38 passedmypy apps/pipeline_worker/backfill_features.py: passed