Hide official backtest inputs and align Basic preview - #172
Merged
Conversation
hjcud
marked this pull request as ready for review
August 9, 2026 16:32
hjcud
force-pushed
the
feature/official-backtest-inputs-hidden
branch
from
August 9, 2026 16:38
b78f81e to
fb24059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root causes
The launch dialog exposed immutable infrastructure inputs as user choices. Reopening an already validated strategy discarded its validation-run ID even though the existing current-validation GET API still returned it. The preview independently used only the first recognized indicator, silently ignored data/risk conditions, used Wilder RSI instead of the pinned
rsi:1.0.0bounded-window definition, and fabricated a current-close fill when no next bar existed.User impact
Users now provide only product inputs (cash and budget). Internal official inputs are selected automatically. Reopened validated strategies can be launched directly, while any edit immediately revokes that restored launchability. Preview arrows are emitted only when all configured conditions can be evaluated and pass; otherwise the UI explains the conditions and shows an honest warning instead of a plausible but wrong signal.
Validation
pnpm test --run— 48 files / 588 tests passed on the final candidatepnpm typecheck— passedpnpm build— passedpnpm e2e— 10 Chromium journeys passedgit diff --check— passedExternal dependency found during AWS read-only verification
The existing market-data endpoint is backed by the live Redis cache. AAPL currently has only 13×30m, 7×1h, 2×4h, and 1×1d bars, which is insufficient even for RSI(14). A backend-owned read endpoint must return sufficient official adjusted historical bars (including warm-up) before AWS can display reliable preview signals. This is an INT03-A-adjacent read capability only; this PR does not touch live trading or INT03-B.