Skip to content

Hide official backtest inputs and align Basic preview - #172

Merged
hjcud merged 1 commit into
developfrom
feature/official-backtest-inputs-hidden
Aug 9, 2026
Merged

Hide official backtest inputs and align Basic preview#172
hjcud merged 1 commit into
developfrom
feature/official-backtest-inputs-hidden

Conversation

@hjcud

@hjcud hjcud commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

What changed

  • hide dataset-manifest and execution-policy choices from the personal-bot launch dialog
  • automatically submit the server-ordered current official dataset and execution policy
  • clear stale release inputs before every refresh so a failed refresh cannot launch with old values
  • restore the exact current valid validation run when a saved strategy is reopened, so a launchable strategy stays launchable without another save
  • fetch preview bars at the partition's selected timeframe instead of hard-coding 30m
  • show the configured buy/sell conditions and an explicit insufficient-history warning
  • evaluate every condition in a Basic container as an AND chain and fail the entire flow closed when any condition is unsupported
  • cover all 12 published Basic condition blocks plus scheduled entry, including position/holding/peak/drawdown state
  • align RSI, MACD, Bollinger, next-bar fill, direction aliases, and execution limits with the production backtest semantics

Root causes

The launch dialog exposed immutable infrastructure inputs as user choices. Reopening an already validated strategy discarded its validation-run ID even though the existing current-validation GET API still returned it. The preview independently used only the first recognized indicator, silently ignored data/risk conditions, used Wilder RSI instead of the pinned rsi:1.0.0 bounded-window definition, and fabricated a current-close fill when no next bar existed.

User impact

Users now provide only product inputs (cash and budget). Internal official inputs are selected automatically. Reopened validated strategies can be launched directly, while any edit immediately revokes that restored launchability. Preview arrows are emitted only when all configured conditions can be evaluated and pass; otherwise the UI explains the conditions and shows an honest warning instead of a plausible but wrong signal.

Validation

  • pnpm test --run — 48 files / 588 tests passed on the final candidate
  • pnpm typecheck — passed
  • pnpm build — passed
  • pnpm e2e — 10 Chromium journeys passed
  • focused current-validation/launch tests — 28 passed
  • focused Basic editor/preview tests — 50 passed
  • git diff --check — passed

External dependency found during AWS read-only verification

The existing market-data endpoint is backed by the live Redis cache. AAPL currently has only 13×30m, 7×1h, 2×4h, and 1×1d bars, which is insufficient even for RSI(14). A backend-owned read endpoint must return sufficient official adjusted historical bars (including warm-up) before AWS can display reliable preview signals. This is an INT03-A-adjacent read capability only; this PR does not touch live trading or INT03-B.

@hjcud
hjcud marked this pull request as ready for review August 9, 2026 16:32
@hjcud
hjcud force-pushed the feature/official-backtest-inputs-hidden branch from b78f81e to fb24059 Compare August 9, 2026 16:38
@hjcud
hjcud merged commit 3059bc3 into develop Aug 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant