#188 Implement the linting and formatting FIXED#224
Merged
Nanafancy merged 2 commits intoJul 7, 2026
Merged
Conversation
|
@solidsole Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…g test/lint failures
Contributor
Author
|
@Nanafancy PLEASE REVIEW AND PING ME BACK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings
No workspace-level pre-commit hook existed
.githooks.Linting/formatting was inconsistent across projects
ignition-apihad ESLint and Prettier scripts.packages/core-tshad ESLint only, and it was partly broken.ignition-pay-frontendhad a lint script but no committed ESLint config for this setup.packages/core-tslinting had a real setup issue@typescript-eslint/parserwas missing.Number(...).Frontend needed explicit lint/format support
ignition-pay-frontendneeded:There are unrelated existing issues in
ignition-apiCLOSE #188
Fix features implemented
Committed Git hook
.githooks/pre-commitAutomatic hook installation
preparescript in rootpackage.jsonscripts/setup-git-hooks.mjsCentral staged-file pre-commit runner
scripts/pre-commit-checks.mjsShared formatting config
.prettierrc.json.prettierignoreJavaScript/TypeScript staged checks
ignition-apiignition-pay-frontendpackages/core-tsThese run:
--fixDart/Flutter staged checks
packages/core-dartdart formatdart analyzeignition-mobiledart formatflutter analyze --no-pubGo staged checks
packages/core-gogofmt -wgo test ./...Core TS lint fix
Frontend lint/format support
ignition-pay-frontend/eslint.config.mjslint:fixformatformat:checkAPI helper scripts
ignition-api/package.json:lint:checkformat:checkCONTRIBUTING.mdto explain: