Skip to content

notify-send as fallback #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yrps wants to merge 6 commits into
base: next
Choose a base branch
from
Open

notify-send as fallback #73

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8af352b
if spacefm, elif zenity, else notify-send.
Nov 26, 2016
a64a284
DRY with msg and msgtitle. Remove extraneous grep from pipe.
Nov 27, 2016
67815dc
Double backslash shouldn't be needed in single quotes.
Nov 27, 2016
a099948
Trim trailing whitespace.
Nov 27, 2016
0a00554
Square bracket (test operator) is not for testing return codes.
Nov 27, 2016
cba6518
Improve tabular layout of info on mount text.
Nov 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 62 additions & 32 deletions src/devmon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Script Name: devmon http://igurublog.wordpress.com/downloads/script-devmon/
# Script Name: devmon http://igurublog.wordpress.com/downloads/script-devmon/
# Requires: udevil bash>=4 Recommended: eject spacefm|zenity
# Optional: udisks v1 may be substituted for udevil
# If udevil is not set suid, udisks v1/v2 or pmount is required
Expand Down Expand Up @@ -78,7 +78,7 @@ test2()
if [ "${2:0:1}" = "-" ] || [ "$2" = "" ]; then
echo "devmon: Option $1 requires an argument" 1>&2
exit 1
fi
fi
}

test3()
Expand All @@ -87,7 +87,7 @@ test3()
[ "${3:0:1}" = "-" ] || [ "$3" = "" ]; then
echo "devmon: Option $1 requires two arguments" 1>&2
exit 1
fi
fi
}

unknown()
Expand Down Expand Up @@ -247,7 +247,7 @@ while [ "$1" != "" ]; do
igdev[$igdevx]="$2"
(( igdevx++ ))
shift
;;
;;
--ignore-label )
test2 "$1" "$2"
iglab[$iglabx]="$2"
Expand Down Expand Up @@ -344,6 +344,7 @@ udisks2=`which udisksctl 2>/dev/null`
pmount=`which pmount 2>/dev/null`
zenity=`which zenity 2>/dev/null`
spacefm=`which spacefm 2>/dev/null`
notify_send=`which notify-send 2>/dev/null`

if [ "$udevil" != "" ] && [ -x "$udevil" ]; then
info_cmd="$udevil"
Expand Down Expand Up @@ -380,7 +381,7 @@ if [ "$mount_cmd" = "" ]; then
fi


driveinfo() #$1=dev #Optional $2=quiet
driveinfo() #$1=dev #Optional $2=quiet
{
unset systeminternal usage ismounted presentationnopolicy hasmedia \
opticaldisc numaudiotracks type partition media blank label
Expand Down Expand Up @@ -518,9 +519,9 @@ mountdev() # $1=device [$2=label] [$3=devtype or fstype]
mntmsg="devmon: $mount_cmd --mount $1 --mount-options \"$mopts\" $fst $mountfstype $lblcmt"
fi
if [ "$3" != "nofs" ]; then
echo "$mntmsg"
echo "$mntmsg"
fi

# mount
if [ "$mount_cmd" = "$udisks2" ]; then
umsg=`$mount_cmd mount -b $1 -o "$mopts" $fst $mountfstype 2>&1`
Expand All @@ -538,7 +539,7 @@ mountdev() # $1=device [$2=label] [$3=devtype or fstype]
point=" "
fi
if [ "$mounterr" != "0" ] || [ "$point" = "" ]; then
# if $3=nofs then there was no apparent filesystem but we tried to mount it
# if $3=nofs then there was no apparent filesystem but we tried to mount it
# anyway in case it didn't report the filesystem accurately, so ignore the
# error
if [ "$3" != "nofs" ]; then
Expand All @@ -548,12 +549,25 @@ mountdev() # $1=device [$2=label] [$3=devtype or fstype]
if (( mountmode == 0 )) && (( polkiterrgiven != 1 )) && \
[ "$(echo "$umsg" | grep 'Not *Authorized')" != "" ]; then
if (( nogui != 1 )); then
msgtitle="devmon error"
read -rd'\0' msg <<-MSG
udisks functions are not authorized through policykit,
so devmon cannot automount drives.
Please install udevil or see devmon's consolekit installation instructions:

http://igurublog.wordpress.com/downloads/script-devmon/#install

(To silence this pop-up add --no-gui to devmon's command line.)
MSG
if [ "$spacefm" != "" ]; then
( sleep 3 && $spacefm -g --title "devmon error" --window-icon error --label "udisks functions are not authorized through policykit,\nso devmon cannot automount drives.\nPlease install udevil or see devmon's consolekit installation instructions:\n\nhttp://igurublog.wordpress.com/downloads/script-devmon/#install\n\n(To silence this pop-up add --no-gui to devmon's command line.)" --button "Open Website" xdg-open "http://igurublog.wordpress.com/downloads/script-devmon/#install" --button ok &> /dev/null ) &
( sleep 3 && $spacefm -g --title "$msgtitle" --window-icon error --label "$msg" --button "Open Website" xdg-open "http://igurublog.wordpress.com/downloads/script-devmon/#install" --button ok &> /dev/null ) &
elif [ "$zenity" != "" ]; then
( sleep 3 && WINDOWID="" $zenity --error --no-wrap --title="$msgtitle" \
--text="$msg" &> /dev/null ) &
else
( sleep 3 && WINDOWID="" $zenity --error --no-wrap --title="devmon error" \
--text="udisks functions are not authorized through policykit,\nso devmon cannot automount drives.\nPlease install udevil or see devmon's consolekit installation instructions:\n\nhttp://igurublog.wordpress.com/downloads/script-devmon/#install\n\n(To silence this pop-up add --no-gui to devmon's command line.)" &> /dev/null ) &
( sleep 3 && $notify_send --icon=dialog-error "$msgtitle" "$msg" &> /dev/null ) &
fi
unset msg msgtitle
fi
echo "@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@" 1>&2
echo "@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@" 1>&2
Expand All @@ -562,7 +576,7 @@ mountdev() # $1=device [$2=label] [$3=devtype or fstype]
echo "Please see devmon's consolekit installation instructions:" 1>&2
echo "http://igurublog.wordpress.com/downloads/script-devmon/#install" 1>&2
echo "@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@" 1>&2
echo "@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@" 1>&2
echo "@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@" 1>&2
polkiterrgiven=1
fi
fi
Expand All @@ -573,13 +587,13 @@ mountdev() # $1=device [$2=label] [$3=devtype or fstype]
# no filesystem reported but successful mount
echo "$mntmsg"
fi

# set devtag for recognizing mounted by devmon
devpath="$1"
devtag="${devpath#/dev/}"
devtag="${devtag//-/_}"
eval devmounted${devtag}=1

echo "$umsg"
if [ "$point" = " " ]; then
# pmount doesn't output the mount point - get it now
Expand All @@ -603,13 +617,13 @@ unmountdev() # $1=device
fi
umounterr="$?"
if [ "$mount_cmd" = "$udisks1" ] && [ "$uerrmsg" != "" ]; then
# bug: udisks v1 returns $?==0 when unmount fails
# bug: udisks v1 returns $?==0 when unmount fails
umounterr=1
fi
if [ "$uerrmsg" != "" ]; then
echo "$uerrmsg"
fi
if [ $umounterr -ne 0 ]; then
if [ $umounterr -ne 0 ]; then
uerr=3
return 3
fi
Expand Down Expand Up @@ -721,15 +735,23 @@ mountdrive() # $1=device $2=label [$3=devtype or fstype]
sleep .5
echo "devmon: [info on mount] $dv"
if (( nogui != 1 )); then
msgtitle="devmon mount"
msg="$(df -hT "$dv" | awk '
BEGIN { l = 7; printf "The following device has been mounted:\n\n" }
NR == 1 { split($0, h); h[1] = "Device"; h[7] = "Mount"; delete h[8] }
NR == 2 { for (i = 1; i <= NF; i++) printf "%-*s\t%s\n", l, h[i]":", $i }
END { printf "%-*s\t%s", l, "Label:", "'$lb'" }
')"
if [ "$spacefm" != "" ]; then
$spacefm -g --title "devmon mount" --window-icon drive-removable-media --label \
"The following device has been mounted:\n\n$(df -hT "$dv" | grep "$dv" | \
awk '{print "Device:\\t"$1"\x0AType:\\t"$2"\nSize:\\t\\t"$3"\nUsed:\\t"$4"\n""Avail:\\t"$5"\nUse%:\\t"$6"\nMount:\\t"$7,$8,$9,$10}')\nLabel:\\t$lb" \
$spacefm -g --title "$msgtitle" --window-icon drive-removable-media --label \
"$msg" \
--button open spacefm "$point" --button ok &>/dev/null &
elif [ "$zenity" != "" ]; then
WINDOWID="" $zenity --info --text="$msg" --title="$msgtitle" &
else
WINDOWID="" $zenity --info --text="The following device has been mounted:\n\n$(df -hT "$dv" \
| grep "$dv" | awk '{print "Device:\\t"$1"\x0AType:\\t"$2"\nSize:\\t\\t"$3"\nUsed:\\t"$4"\n""Avail:\\t"$5"\nUse%:\\t"$6"\nMount:\\t"$7,$8,$9,$10}')\nLabel:\\t$lb" --title="devmon mount" &
$notify_send --icon=media-removable "$msgtitle" "$msg" &
fi
unset msgtitle msg
fi
df -hT "$dv"
fi
Expand Down Expand Up @@ -792,7 +814,7 @@ mountalldrives()
fi
fi
done
IFS="$IFSOLD"
IFS="$IFSOLD"
}

trapexit()
Expand Down Expand Up @@ -888,8 +910,10 @@ if (( mountmode != 0 )); then
if (( nogui != 1 )); then
if [ "$spacefm" != "" ]; then
spacefm -g --title "$msgtitle" --label "$msg" --button close &> /dev/null &
else
elif [ "$zenity" != "" ]; then
WINDOWID="" zenity --info --title="$msgtitle" --text="$msg" &> /dev/null &
else
"$notify_send" --icon=media-eject "$msgtitle" "$msg" &> /dev/null &
fi
zpid=$!
fi
Expand All @@ -909,10 +933,12 @@ if (( mountmode != 0 )); then
if [ "$spacefm" != "" ]; then
spacefm -g --title "$msgtitle" --window-icon error \
--label "$msg" --button close &> /dev/null &
else
elif [ "$zenity" != "" ]; then
WINDOWID="" zenity --error --title="$msgtitle" --text="$msg" &> /dev/null &
else
"$notify_send" --icon=dialog-error "$msgtitle" "$msg" &> /dev/null &
fi
fi
fi
done
echo "devmon: sync"
sync
Expand Down Expand Up @@ -945,16 +971,20 @@ if (( mountmode != 0 )); then
else
lb=" ($label)"
fi
msgtitle="devmon unmount optical"
msg="Unmount error on /dev/sr$x$lb:\n\n$uerrmsg"
if [ "$spacefm" != "" ]; then
spacefm -g --title "devmon unmount optical" \
spacefm -g --title "$msgtitle" \
--window-icon error \
--label "$msg" --button close &> /dev/null &
else
WINDOWID="" zenity --error --title="devmon unmount optical" \
elif [ "$zenity" != "" ]; then
WINDOWID="" zenity --error --title="$msgtitle" \
--text="$msg" &> /dev/null &
else
"$notify_send" --icon=dialog-error "$msgtitle" "$msg"
fi
fi
unset msgtitle msg
fi
fi
fi
(( x++ ))
Expand Down Expand Up @@ -1051,7 +1081,7 @@ if (( mountmode != 0 )); then
(( x++ ))
done
fi

# Mount DEVICE
if (( mntx > 0 )); then
x=0
Expand All @@ -1071,7 +1101,7 @@ if (( mountmode != 0 )); then
mountdev $d "$label" "$type"
fi
(( x++ ))
done
done
fi

# Mount All Unmounted
Expand Down Expand Up @@ -1120,7 +1150,7 @@ err=$?
trap trapexit EXIT SIGINT SIGTERM SIGQUIT
trap "echo devmon: ignored HUP" SIGHUP

if [ $err != "0" ] || [ ! ps -p $COPROC_PID &>/dev/null ]; then
if [ $err != "0" ] || ! ps -p $COPROC_PID &>/dev/null; then
echo "devmon: unable to start $info_cmd --monitor" 1>&2
exit 2
fi
Expand Down