#80 Improve boundary layer models with compressible DeChant skin friction/Van Driest heat flux.#85
Open
#80 Improve boundary layer models with compressible DeChant skin friction/Van Driest heat flux.#85
Conversation
…ied independently.
…ection needs to be implemented.
Fixed bug where outflow BC was applied to left boundary.
Collaborator
|
@nlaing613 I think this is good to go! All of the tests and example cases look good to me. The results from optimization.py seem to be a little bit different, might be worth digging into that a bit more later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces compressible closed-form models for skin friction and wall heat flux and modularizes these models and their inputs.
The main changes are located in:
models/wall_models.pyContains separate heat flux and skin friction classes and wall-state (key parameters used by models).
models/boundary_layer.pySimplified calculation by offloading to
wall_models.py.Included changes
wall_models=(SkinFriction, HeatFlux)(get_wall_state), decoupling wall-model evaluations from the core solver and enabling modular skin-friction and heat-flux models