Conversation
…ied independently.
…ection needs to be implemented.
Fixed bug where outflow BC was applied to left boundary.
Collaborator
|
@nlaing613 @jjhans There are two main things which I'm thinking about, here:
I still think the CSV writer is worthwhile as a runtime output option, similar to the probes. It should be possible to insert more complex functions into the I'll take a pass at adding this functionality soon! |
6c0f702 to
613f00c
Compare
613f00c to
bccc9df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know @jjhans built the original but since I pushed the most recent version I thought I'd go ahead and explain the logic of the version I pushed so we can discuss everything.
The main summary is that at a user-selected interval, the primitives, sound-speed, temperature, and cell-centers are written to the file according to a fixed precision. This is meant to replace the previous spatial for-loop that collected the fluid state; I found it slowed down the runs significantly.
The original version computed the heat flux within the
csv_writer.py, but I believe this should be linked to the actual boundary layer evaluation; that said, I haven't had the chance to link this. It might also be helpful to add the skin friction coefficient. Regardless, both are omitted in this version. I still like the idea and would like to include them.@TimothyEDawson, I understand you mentioned changing the file formatting to hdf5 to be compatible with restart files. Is this something we want to pursue further? I probably need to get up to speed with the restart functionality, I admit I haven't used it yet.